fix: use inline source maps when present in js #8995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitsonk
reviewed
Jan 5, 2021
bartlomieju
reviewed
Jan 5, 2021
bartlomieju
reviewed
Jan 5, 2021
kitsonk
approved these changes
Jan 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also fixes source_line mapping, because currently it was making some wrong (but up to now correct) assumptions about where to get the source map info from. This has been corrected. The order of priority for source line info is now 1. the inline source map sourcesContent, 2. the module graph, and 3. the original source_line form the transpiled code.
Towards #4499.