Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add web platform test runner #8990

Merged
merged 12 commits into from
Jan 5, 2021
Merged

Conversation

lucacasonato
Copy link
Member

@lucacasonato lucacasonato commented Jan 4, 2021

Closes #6229

cc @kitsonk I only enabled a minimal set of tests for streams, because most of the rest does not work. We can start enabling them one by one in follow ups.

Files are all concatenated together, because WPT tests are meant to work with scripts, not modules. Once we support external source mapping, I will add source mapping for WPT tests. I have added source mapping. I have checked that it works with #8995.

Copy link
Contributor

@kitsonk kitsonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple thoughts/nits

.gitmodules Outdated Show resolved Hide resolved
cli/tests/wpt_testharnessconsolereporter.js Outdated Show resolved Hide resolved
cli/tests/wpt_testharnessconsolereporter.js Outdated Show resolved Hide resolved
cli/tests/wpt_testharnessconsolereporter.js Outdated Show resolved Hide resolved
Copy link
Contributor

@kitsonk kitsonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! LGTM.

@axetroy
Copy link
Contributor

axetroy commented Jan 5, 2021

This is really awesome!

If you can output the test results to a JSON file and render them in https://deno.land, that would be great

@lucacasonato
Copy link
Member Author

If you can output the test results to a JSON file and render them in https://deno.land, that would be great

Sounds like a good idea. Will investigate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

discussion: Run web platform tests
3 participants