Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(std/wasi): run test runner with --no-check #8710

Merged
merged 1 commit into from
Dec 10, 2020
Merged

test(std/wasi): run test runner with --no-check #8710

merged 1 commit into from
Dec 10, 2020

Conversation

caspervonb
Copy link
Contributor

@caspervonb caspervonb commented Dec 10, 2020 •
edited
Loading

This runs the test runner with --no-check which shaves the time taken down from a bit over 1 minute to 5 seconds.

We still import "snapshot_preview1" file in the test file that prepares the test runner invocations so we still get type checking there, just omitting it in the runner.

@caspervonb
test(std/wasi): run test runner with --no-check
7ada229 
This runs the test runner with --no-check which shaves the time taken
down from a bit over 1 minute to 5 seconds.
@caspervonb
Copy link
Contributor Author

This patch

$ time deno test --allow-all --unstable std/wasi

real	0m4.143s
user	0m6.040s
sys	0m0.821s

Master

$ time deno test --allow-all --unstable std/wasi

real	0m49.151s
user	1m26.559s
sys	0m2.713s

lucacasonato
lucacasonato approved these changes Dec 10, 2020
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks

@lucacasonato lucacasonato merged commit c5ccbf3 into denoland:master Dec 10, 2020
mayankagarwals added a commit to mayankagarwals/deno that referenced this pull request Dec 30, 2020
@mayankagarwals
Commit to adapt the feature to denoland#8710 and denoland#8622
60bf234
mayankagarwals added a commit to mayankagarwals/deno that referenced this pull request Dec 30, 2020
@mayankagarwals
Commit to adapt the feature to denoland#8622 and denoland#8710
1a205cb
mayankagarwals added a commit to mayankagarwals/deno that referenced this pull request Dec 31, 2020
@mayankagarwals
Commit to adapt the feature to denoland#8622 and denoland#8710
94dcf8f
mayankagarwals added a commit to mayankagarwals/deno that referenced this pull request Dec 31, 2020
@mayankagarwals
Commit to adapt the feature to denoland#8710 and denoland#8622
028a082
mayankagarwals added a commit to mayankagarwals/deno that referenced this pull request Dec 31, 2020
@mayankagarwals
Commit to adapt the feature to denoland#8622 and denoland#8710
3623949
mayankagarwals added a commit to mayankagarwals/deno that referenced this pull request Dec 31, 2020
@mayankagarwals
Commit to adapt the feature to denoland#8710 and denoland#8622
01ace45
mayankagarwals added a commit to mayankagarwals/deno that referenced this pull request Dec 31, 2020
@mayankagarwals
Commit to adapt the feature to denoland#8710 and denoland#8622
70264e7
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 21, 2021
@caspervonb
test(std/wasi): run test runner with --no-check (denoland/deno#8710)
0fdfafa
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@caspervonb
test(wasi): run test runner with --no-check (denoland/deno#8710)
34d03c4
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@caspervonb
test(wasi): run test runner with --no-check (denoland/deno#8710)
8572cc1
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@caspervonb
test(wasi): run test runner with --no-check (denoland/deno#8710)
cd0c8ee
mayankagarwals added a commit to mayankagarwals/deno that referenced this pull request Jan 26, 2021
@mayankagarwals
Commit to adapt the feature to denoland#8622 and denoland#8710
39f77f0
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@caspervonb
test(wasi): run test runner with --no-check (denoland/deno#8710)
a8507fc
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@caspervonb
test(wasi): run test runner with --no-check (denoland/deno#8710)
ff56f16
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@caspervonb
test(wasi): run test runner with --no-check (denoland/deno#8710)
18ca549
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@caspervonb @denobot
test(wasi): run test runner with --no-check (denoland/deno#8710)
67a63da
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Feb 1, 2021
@caspervonb @denobot
test(wasi): run test runner with --no-check (denoland/deno#8710)
4d11cf5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacasonato lucacasonato lucacasonato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caspervonb @lucacasonato