Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(std/wasi): prefer explicit encoder/decoder names #8622

Merged
merged 1 commit into from
Dec 5, 2020
Merged

refactor(std/wasi): prefer explicit encoder/decoder names #8622

merged 1 commit into from
Dec 5, 2020

Conversation

caspervonb
Copy link
Contributor

This renames a couple of identifiers from the ambiguous name "text" to the more explicit textEncoder and textDecoder depending on what they are.

Should have been done in the initial pass to camelCase all the identifiers.

@caspervonb
refactor(std/wasi): prefer explicit encoder/decoder names
28659fa 
This renames a couple of identifiers from the ambigious name "text" to
the more explicit textEncoder and textDecoder depending on what they are.
bartlomieju
bartlomieju approved these changes Dec 5, 2020
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit 4f0dc2c into denoland:master Dec 5, 2020
mayankagarwals added a commit to mayankagarwals/deno that referenced this pull request Dec 30, 2020
@mayankagarwals
Commit to adapt the feature to denoland#8710 and denoland#8622
60bf234
mayankagarwals added a commit to mayankagarwals/deno that referenced this pull request Dec 30, 2020
@mayankagarwals
Commit to adapt the feature to denoland#8622 and denoland#8710
1a205cb
mayankagarwals added a commit to mayankagarwals/deno that referenced this pull request Dec 31, 2020
@mayankagarwals
Commit to adapt the feature to denoland#8622 and denoland#8710
94dcf8f
mayankagarwals added a commit to mayankagarwals/deno that referenced this pull request Dec 31, 2020
@mayankagarwals
Commit to adapt the feature to denoland#8710 and denoland#8622
028a082
mayankagarwals added a commit to mayankagarwals/deno that referenced this pull request Dec 31, 2020
@mayankagarwals
Commit to adapt the feature to denoland#8622 and denoland#8710
3623949
mayankagarwals added a commit to mayankagarwals/deno that referenced this pull request Dec 31, 2020
@mayankagarwals
Commit to adapt the feature to denoland#8710 and denoland#8622
01ace45
mayankagarwals added a commit to mayankagarwals/deno that referenced this pull request Dec 31, 2020
@mayankagarwals
Commit to adapt the feature to denoland#8710 and denoland#8622
70264e7
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 21, 2021
@caspervonb
refactor(std/wasi): prefer explicit encoder/decoder names (denoland/d…
35bc3c9 
…eno#8622)

This renames a couple of identifiers from the ambigious name "text" to
the more explicit textEncoder and textDecoder depending on what they are.
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@caspervonb
refactor(wasi): prefer explicit encoder/decoder names (denoland/deno#…
bda9b03 
…8622)

This renames a couple of identifiers from the ambigious name "text" to
the more explicit textEncoder and textDecoder depending on what they are.
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@caspervonb
refactor(wasi): prefer explicit encoder/decoder names (denoland/deno#…
e5e1c99 
…8622)

This renames a couple of identifiers from the ambigious name "text" to
the more explicit textEncoder and textDecoder depending on what they are.
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@caspervonb
refactor(wasi): prefer explicit encoder/decoder names (denoland/deno#…
420250f 
…8622)

This renames a couple of identifiers from the ambigious name "text" to
the more explicit textEncoder and textDecoder depending on what they are.
mayankagarwals added a commit to mayankagarwals/deno that referenced this pull request Jan 26, 2021
@mayankagarwals
Commit to adapt the feature to denoland#8622 and denoland#8710
39f77f0
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@caspervonb
refactor(wasi): prefer explicit encoder/decoder names (denoland/deno#…
d9fa6ba 
…8622)

This renames a couple of identifiers from the ambigious name "text" to
the more explicit textEncoder and textDecoder depending on what they are.
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@caspervonb
refactor(wasi): prefer explicit encoder/decoder names (denoland/deno#…
7159eda 
…8622)

This renames a couple of identifiers from the ambigious name "text" to
the more explicit textEncoder and textDecoder depending on what they are.
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@caspervonb
refactor(wasi): prefer explicit encoder/decoder names (denoland/deno#…
1a5e8a5 
…8622)

This renames a couple of identifiers from the ambigious name "text" to
the more explicit textEncoder and textDecoder depending on what they are.
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@caspervonb @denobot
refactor(wasi): prefer explicit encoder/decoder names (denoland/deno#…
03a1561 
…8622)

This renames a couple of identifiers from the ambigious name "text" to
the more explicit textEncoder and textDecoder depending on what they are.
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Feb 1, 2021
@caspervonb @denobot
refactor(wasi): prefer explicit encoder/decoder names (denoland/deno#…
a3d29a9 
…8622)

This renames a couple of identifiers from the ambigious name "text" to
the more explicit textEncoder and textDecoder depending on what they are.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caspervonb @bartlomieju