-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] feat(cli): upgrade clap to v3 #8485
Conversation
This reverts commit e2fc9d3
# Conflicts: # cli/flags.rs
blocked by clap-rs/clap#2233 |
Thanks @crowlKats. I like that this upgrade finally gets rid of our ansi_term dependency. (Not so happy it adds clap_generate, clap_derive, heck, proc-macro-error, os_str_bytes, proc-macro-error-attr...) Should we wait for Clap v3.0.0 to be released? Are there any public facing changes? (AFAICT it looks the same.) Can we do this upgrade without using clap_generate? |
I think we should, clap author explicitly state not to upgrade because of more changes being considered for 3.0.
Nope, it's used to generate shell-completions (for |
Ref #8475 As per Discord conversation; we'll land this PR after stable release of Clap v3. Closing for now. |
Closes #8475