Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] feat(cli): upgrade clap to v3 #8485

Closed
wants to merge 19 commits into from
Closed

Conversation

crowlKats
Copy link
Member

@crowlKats crowlKats commented Nov 24, 2020

Closes #8475

@crowlKats crowlKats changed the title feat(cli): upgrade clap to v3 [WIP] feat(cli): upgrade clap to v3 Nov 24, 2020
@crowlKats crowlKats marked this pull request as draft November 25, 2020 13:08
@crowlKats crowlKats marked this pull request as ready for review November 25, 2020 20:24
@crowlKats
Copy link
Member Author

crowlKats commented Nov 29, 2020

blocked by clap-rs/clap#2233

@ry
Copy link
Member

ry commented Dec 6, 2020

Thanks @crowlKats. I like that this upgrade finally gets rid of our ansi_term dependency. (Not so happy it adds clap_generate, clap_derive, heck, proc-macro-error, os_str_bytes, proc-macro-error-attr...)

Should we wait for Clap v3.0.0 to be released? Are there any public facing changes? (AFAICT it looks the same.)

Can we do this upgrade without using clap_generate?

@bartlomieju
Copy link
Member

Thanks @crowlKats. I like that this upgrade finally gets rid of our ansi_term dependency. (Not so happy it adds clap_generate, clap_derive, heck, proc-macro-error, os_str_bytes, proc-macro-error-attr...)

Should we wait for Clap v3.0.0 to be released? Are there any public facing changes? (AFAICT it looks the same.)

I think we should, clap author explicitly state not to upgrade because of more changes being considered for 3.0.

Can we do this upgrade without using clap_generate?

Nope, it's used to generate shell-completions (for deno completions subcommand)

@bartlomieju
Copy link
Member

bartlomieju commented Dec 6, 2020

Ref #8475

As per Discord conversation; we'll land this PR after stable release of Clap v3. Closing for now.

@bartlomieju bartlomieju closed this Dec 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Research upgrade to clap v3
3 participants