Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Research upgrade to clap v3 #8475

Closed
bartlomieju opened this issue Nov 23, 2020 · 6 comments · Fixed by #13266
Closed

Research upgrade to clap v3 #8475

bartlomieju opened this issue Nov 23, 2020 · 6 comments · Fixed by #13266
Assignees
@crowlKats
Labels
cli related to cli/ dir feat new feature (which has been agreed to/accepted) help wanted community help requested refactor

Comments

@bartlomieju
Copy link
Member

Deno uses clap as its CLI parser. It looks like clap v3 is behind the corner so I think it's high time to do some research what it would take to upgrade our cli/flags.rs.

Keep in mind, clap authors recommended to stay on v2.33 still as the API is not fully stable. So I'd be happy to have a PR open until stable v3 is released.
@bartlomieju bartlomieju added cli related to cli/ dir help wanted community help requested l-rust 🦀 refactor labels Nov 23, 2020
@bartlomieju
Copy link
Member Author

Related to #8472

@bartlomieju bartlomieju mentioned this issue Nov 24, 2020
Closed
@bartlomieju bartlomieju mentioned this issue Dec 6, 2020
Closed
@bartlomieju
Copy link
Member Author

@crowlKats did PRs that upgrade to clap v3; we'll land them after stable release of clap v3.

@stale
Copy link

stale bot commented Feb 4, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Feb 4, 2021
@ry ry removed the stale label Feb 4, 2021
@stale
Copy link

stale bot commented Apr 5, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 5, 2021
@stale stale bot closed this as completed Apr 12, 2021
@lucacasonato lucacasonato reopened this Apr 12, 2021
@stale stale bot removed the stale label Apr 12, 2021
@stale
Copy link

stale bot commented Jun 11, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jun 11, 2021
@stale
Copy link

stale bot commented Aug 10, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Aug 10, 2021
@bartlomieju bartlomieju added the feat new feature (which has been agreed to/accepted) label Aug 11, 2021
@stale stale bot removed the stale label Aug 11, 2021
@crowlKats crowlKats mentioned this issue Sep 19, 2021
Closed
@crowlKats crowlKats mentioned this issue Jan 2, 2022
Merged
@crowlKats crowlKats self-assigned this Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crowlKats crowlKats

Labels
cli related to cli/ dir feat new feature (which has been agreed to/accepted) help wanted community help requested refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: clap v3 crowlKats/deno
[WIP] feat(cli): upgrade clap to v3 crowlKats/deno
4 participants
@ry @lucacasonato @crowlKats @bartlomieju