-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add sd-streams from https://github.com/stardazed/sd-streams/blob/mast… #3192
Conversation
Should this be a git submodule rather than vendorize? |
I was wondering this myself, but there are a bunch of changes that we need to make to the sd-source, |
Another option is to fork and float a patch, that way we could rebase over future updates... |
cli/js/dom_types.ts
Outdated
getWriter(): WritableStreamDefaultWriter<W>; | ||
} | ||
|
||
export interface PipeOptions { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are called from cli/js/streams, and seem to be expected to exist in the dom.
I pulled most of these interfaces from https://github.com/microsoft/TypeScript/blob/master/lib/lib.dom.d.ts, I'm not sure whether this is right, or the right place to put these
1fc17b3
to
1cc6eb3
Compare
@nstott I'd like to land this but it's red .. can you look into it? |
will do! |
…msg.rs and errors.ts
That's done it. As far as I could tell, we didn't have an equivalent error type, so I shoved these into the |
This is a lot of code that's being imported. If this is too big, I could stage these imports into smaller pieces. for example, I could rip out the writer and transformer stuff from this pr, as we don't use those features yet, and don't have tests in place yet for that specific functionality. |
FYI - this PR adds 1mb to the release executable on mac:
|
afc153a
to
b75f3fa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thank you !
fixes #2828
@stardazed/streams was removed from
third_party/
in https://github.com/denoland/deno/pull/2826/filesThis adds sd streams from https://github.com/stardazed/sd-streams/tree/8928cf04b035fd02fb1340b7eb541c76be37e546 to
cli/js/streams
and reverts some of #2836I've disabled some lints in cli/js/streams/ in order to get this to pass, I've marked them with TODOs,
As well, There are a few other TODO's that i've noted in streams/. notably, we're missing the DomException, and there are some gross type casts.
as undefined as ..
There seems to be an impedance mismatch in the streams interface, eg, SDReadbleStream vs ReadableStream, but I'm not sure how much that matters at the moment