Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-enable request.body tests #2828

Closed
ry opened this issue Aug 28, 2019 · 3 comments · Fixed by #3192
Closed

re-enable request.body tests #2828

ry opened this issue Aug 28, 2019 · 3 comments · Fixed by #3192

Comments

@ry
Copy link
Member

ry commented Aug 28, 2019

Tests removed here 8f91946#diff-f61b1245115d8e0ef4d9f1149e37b642L18

Move @standardized/streams into //js. Solution outlined here: #2826 (comment)

@mattyclarkson
Copy link

basically we just need to move it into //js rather than have it in node_modules... but the problem is I don't have support for /// <reference types="..."/>, so we need a streams.ts file which includes the TS and JS. Or, I need to add /// <reference types="..."/> support to https://github.com/ry/deno_typescript .... I think porting streams to typescript is the best route for now.

The code for @stardazed/streams is in TypeScript. What do we need to port?

Is there any chance we can get WHATWG streams enabled by default in deno? Happy to help out here: I have some transformers I'd like to use server side, in a CLI and in a service worker.

@mattyclarkson
Copy link

What do we need to port?

Ah just saw that @mrkurt had already said that in his comment

@nstott
Copy link
Contributor

nstott commented Oct 22, 2019

I'd like to give this a shot,

just to clarify my understanding, what needs to be done is to

is that it? anything I'm missing, or should pay attention to?

cc/ @mrkurt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants