Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): consolidate pkg parser for install & remove #26298

Merged
merged 4 commits into from
Oct 16, 2024
Merged

fix(cli): consolidate pkg parser for install & remove #26298

merged 4 commits into from
Oct 16, 2024

Conversation

satyarohith
Copy link
Member

Closes #26283

@satyarohith satyarohith changed the title fix(cli): consolidate pkg parser for install & remove' fix(cli): consolidate pkg parser for install & remove Oct 16, 2024
@satyarohith satyarohith changed the title fix(cli): consolidate pkg parser for install & remove feat(cli): consolidate pkg parser for install & remove Oct 16, 2024
@satyarohith satyarohith changed the title feat(cli): consolidate pkg parser for install & remove fix(cli): consolidate pkg parser for install & remove Oct 16, 2024
marvinhagemeister
marvinhagemeister approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about renaming AddPackageReq to AddRmPackageReq. I feel like the previous name was perfectly fine as it isn't strictly tied to the act of removing packages. I prefer the previous name.

Otherwise LGTM

@satyarohith
Copy link
Member Author

I feel like the previous name was perfectly fine as it isn't strictly tied to the act of removing packages. I prefer the previous name.

After this patch, it is not strictly tied to adding packages either so I renamed it to AddRmPackageReq as reading AddPackageReq::parse() in a remove operation felt out of place even though there is no functionality change.

@marvinhagemeister
Copy link
Contributor

Right, that makes sense! Go ahead with merge 👍

@satyarohith satyarohith enabled auto-merge (squash) October 16, 2024 09:08
@satyarohith satyarohith merged commit 2929d58 into denoland:main Oct 16, 2024
17 checks passed
@satyarohith satyarohith deleted the fix_deno_remove branch October 16, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

deno remove should support jsr:<package_name>@version
2 participants
@satyarohith @marvinhagemeister