Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deno remove should support jsr:<package_name>@version #26283

Closed
bartlomieju opened this issue Oct 15, 2024 · 0 comments · Fixed by #26298
Closed

deno remove should support jsr:<package_name>@version #26283

bartlomieju opened this issue Oct 15, 2024 · 0 comments · Fixed by #26298
Assignees
@satyarohith
Labels
bug Something isn't working correctly

Comments

@bartlomieju
Copy link
Member 

$ deno install jsr:@dnl-fm/[email protected]
Add jsr:@dnl-fm/[email protected]

$ deno remove jsr:@dnl-fm/[email protected]
No packages were removed

It's a common pitfall that I've seen several times already that users use the exact same syntax for removing as for adding. We should support it. Either strip out prefix and version constraint or check for values in the imports/dependencies map.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@satyarohith satyarohith

Labels
bug Something isn't working correctly
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(cli): consolidate pkg parser for install & remove satyarohith/deno
2 participants
@bartlomieju @satyarohith