Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(flags): allow double commas to escape values in path based flags #25453

Merged
merged 4 commits into from
Sep 5, 2024
Merged

feat(flags): allow double commas to escape values in path based flags #25453

merged 4 commits into from
Sep 5, 2024

Conversation

crowlKats
Copy link
Member

Fixes #6553
Fixes #9535

@bartlomieju bartlomieju mentioned this pull request Sep 5, 2024
Closed
dsherret
dsherret approved these changes Sep 5, 2024
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crowlKats crowlKats merged commit b54347c into denoland:main Sep 5, 2024
17 checks passed
@crowlKats crowlKats deleted the escape-double-commas branch September 5, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@crowlKats @dsherret