Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow --ignore to be used with directories and filenames containing a comma #9535

Closed
caspervonb opened this issue Feb 18, 2021 · 1 comment · Fixed by #25453
Closed

Allow --ignore to be used with directories and filenames containing a comma #9535

caspervonb opened this issue Feb 18, 2021 · 1 comment · Fixed by #25453
Assignees
Labels
suggestion suggestions for new features (yet to be agreed)
Milestone

Comments

@caspervonb
Copy link
Contributor

This is the same issue as with --allow-read described in #6553 but for the --ignore option.

Today, this wont work because we use a comma delimited list for this option:

mkdir "foo, bar, "baz"
deno lint --unstable --ignore="./foo, bar, baz"

I intend to change this to be a "multiple" option configuration so that we can pass in paths with commas, multiple will be specified by repeating the option:

mkdir "foo, bar, "baz"
deno lint --unstable \
  --ignore="./foo, bar, baz"
  --ignore="other directory"

Breaking change CLI in multiple commands so probably 2.0.

@kitsonk kitsonk added the suggestion suggestions for new features (yet to be agreed) label Feb 18, 2021
@lucacasonato
Copy link
Member

We'll use the same solution as #6553 (comment) here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
suggestion suggestions for new features (yet to be agreed)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants