Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(publish): error for missing version constraints on dry-publish instead of just publish #23798

Merged
merged 2 commits into from
May 14, 2024
Merged

fix(publish): error for missing version constraints on dry-publish instead of just publish #23798

merged 2 commits into from
May 14, 2024

Conversation

dsherret
Copy link
Member

Closes #22835

@dsherret dsherret requested a review from bartlomieju May 14, 2024 02:17
lucacasonato
lucacasonato approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsherret dsherret merged commit c6189e2 into denoland:main May 14, 2024
17 checks passed
@dsherret dsherret deleted the fix_publish_error_missing_version_constraints branch May 14, 2024 14:30
bartlomieju pushed a commit that referenced this pull request May 16, 2024
@dsherret @bartlomieju
fix(publish): error for missing version constraints on dry-publish in…
5a766b1 
…stead of just publish (#23798)

Closes #22835
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacasonato lucacasonato lucacasonato approved these changes

@bartlomieju bartlomieju Awaiting requested review from bartlomieju

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

deno publish --dry-run do not check specifier jsr: version constraint
2 participants
@dsherret @lucacasonato