Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deno publish --dry-run do not check specifier jsr: version constraint #22835

Closed
hugoalh opened this issue Mar 10, 2024 · 1 comment · Fixed by #23798
Closed

deno publish --dry-run do not check specifier jsr: version constraint #22835

hugoalh opened this issue Mar 10, 2024 · 1 comment · Fixed by #23798
Labels
bug Something isn't working correctly publish Related to "deno publish" subcommand

Comments

@hugoalh
Copy link

hugoalh commented Mar 10, 2024

Happened on Deno v1.41.2, not tested on other versions.

For example, at the script:

import { escape } from "https://deno.land/[email protected]/regexp/escape.ts";

And at the config (look at the missing version constraint at the right side):

{
  "imports": {
    "https://deno.land/[email protected]/regexp/escape.ts": "jsr:@std/regexp/escape"
  }
}

Then run deno publish --dry-run, and it is success.

However, run deno publish and it is fail:

error: Failed to publish @XXXX/XXXX@XXXX

Caused by:
    Failed to publish @XXXX/XXXX at XXXX: specifier 'jsr:@std/regexp/escape' is missing a version constraint

deno publish --dry-run should also check specifier jsr: version constraint.

@hugoalh hugoalh changed the title deno publish --dry-run do not check specifier "jsr:@XXXX/XXXX" version constraint deno publish --dry-run do not check specifier jsr: version constraint Mar 10, 2024
@NfNitLoop
Copy link

Just ran into this myself as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working correctly publish Related to "deno publish" subcommand
Projects
None yet
3 participants