fix(runtime): Restore default signal handler after user handlers are unregistered #22757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe this also fixes a long standing issue: #7164 |
mmastrac
reviewed
Mar 6, 2024
mmastrac
reviewed
Mar 8, 2024
| @@ -237,6 +237,7 @@ Deno.test({ | |||
|
|
|||
| Deno.test({ | |||
| name: "process.off signal", | |||
| ignore: Deno.build.os == "windows", | |||
There was a problem hiding this comment.
👍
LGTM, do we have an issue for process.off not working on Windows?
There was a problem hiding this comment.
Dug a little deeper on this, turns out it's a process.off issue, it's a more general signal sending issue on windows (#22846)
nathanwhit
added a commit
that referenced
this pull request
Mar 14, 2024
…unregistered (#22757) <!-- Before submitting a PR, please read https://docs.deno.com/runtime/manual/references/contributing 1. Give the PR a descriptive title. Examples of good title: - fix(std/http): Fix race condition in server - docs(console): Update docstrings - feat(doc): Handle nested reexports Examples of bad title: - fix #7123 - update docs - fix bugs 2. Ensure there is a related issue and it is referenced in the PR text. 3. Ensure there are tests that cover the changes. 4. Ensure `cargo test` passes. 5. Ensure `./tools/format.js` passes without changing files. 6. Ensure `./tools/lint.js` passes. 7. Open as a draft PR if your work is still in progress. The CI won't run all steps, but you can add '[ci]' to a commit message to force it to. 8. If you would like to run the benchmarks on the CI, add the 'ci-bench' label. --> Fixes #22724. Fixes #7164. This does add a dependency on `signal-hook`, but it's just a higher level API on top of `signal-hook-registry` (which we and `tokio` already depend on) and doesn't add any transitive deps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22724. Fixes #7164.
This does add a dependency on
signal-hook, but it's just a higher level API on top ofsignal-hook-registry(which we andtokioalready depend on) and doesn't add any transitive deps.