Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests that send signals don't work on Windows #22846

Open
nathanwhit opened this issue Mar 11, 2024 · 0 comments
Open

Tests that send signals don't work on Windows #22846

nathanwhit opened this issue Mar 11, 2024 · 0 comments
Labels
tests related to tests

Comments

@nathanwhit
Copy link
Member

Originally spotted in #22757 (comment).

Many tests, such as the process.off signal test, involve sending signals to processes via ChildProcess.kill or Deno.kill. It turns out that windows doesn't really have an easy programmatic way of sending "signals", and so our implementations actually just kill the process. This means that a lot of the signal handling code for windows lacks unit tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests related to tests
Projects
None yet
Development

No branches or pull requests

2 participants