Fix deno.open permission check #1336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
F001
reviewed
Dec 13, 2018
| @@ -594,28 +594,49 @@ fn op_open( | |||
| open_options.read(true); | |||
| } | |||
| "r+" => { | |||
| if let Err(e) = state.check_write(&filename_str) { | |||
There was a problem hiding this comment.
These checks are repeative. What about combining them together?
// add this before the `match mode`
match mode {
"r+" | "w" | "w+" | "a" | "a+" | "x" | "x+" => {
if let Err(e) = state.check_write(&filename_str) {
return odd_future(e);
}
}
_ => {}
}
// original code
match mode {
// set open_options
}There was a problem hiding this comment.
Hmm, does this slightly add some overhead by doing 2 separate matchings?
There was a problem hiding this comment.
Is the r mode the only one that does not need write permission? What about
// original code
match mode {
}
if mode != "r" { // mode is guaranteed to be valid
// only need to write check_write() once
} 
ry
added a commit
to ry/deno
that referenced
this pull request
Dec 14, 2018
- console.assert should not throw error (denoland#1335) - Support more modes in deno.open (denoland#1282, denoland#1336) - Simplify code fetch logic (denoland#1322) - readDir entry mode (denoland#1326) - Use stderr for exceptions (denoland#1303) - console.log formatting improvements (denoland#1327, denoland#1299) - Expose TooLarge error code for buffers (denoland#1298)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
deno.opendoes not do any write permission checks...This PR adds such checks.