-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
console.assert
should not throw error
#1335
Conversation
4c295b9
to
dcb69f5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool - I didn't know that. Looks good.
Can you please remove the additional integration tests you added? Those are relatively expensive to run and I don't think it's warranted for this. The unit test you added is sufficient.
I have deleted the integration tests. Shouldn't
before:
after:
|
I found a typo error in tests, I seny another pr #1342 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks
- console.assert should not throw error (denoland#1335) - Support more modes in deno.open (denoland#1282, denoland#1336) - Simplify code fetch logic (denoland#1322) - readDir entry mode (denoland#1326) - Use stderr for exceptions (denoland#1303) - console.log formatting improvements (denoland#1327, denoland#1299) - Expose TooLarge error code for buffers (denoland#1298)
In the previous implementation #102,
console.assert
throws an error. I thinkconsole.assert
should not throw an error.And in https://console.spec.whatwg.org/#assert,
console.assert
is defined as follows: