-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for create-svelte
#21024
Comments
Thanks! The usage of these APIs in
|
Thanks, re-opened them |
Workaround the circular references issue by using a initializer function to give tty stream class to `initStdin`. Fixes #21024 Fixes #20611 Fixes #20890 Fixes #20336 `create-svelte` works now: ``` divy@mini /t/a> ~/gh/deno/target/debug/deno run -A --unstable --reload npm:create-svelte@latest sveltekit-deno create-svelte version 5.1.1 ┌ Welcome to SvelteKit! │ ◇ Which Svelte app template? │ Skeleton project │ ◇ Add type checking with TypeScript? │ Yes, using JavaScript with JSDoc comments │ ◇ Select additional options (use arrow keys/space bar) │ none │ └ Your project is ready! ✔ Type-checked JavaScript https://www.typescriptlang.org/tsconfig#checkJs Install community-maintained integrations: https://github.com/svelte-add/svelte-add Next steps: 1: cd sveltekit-deno 2: npm install 3: git init && git add -A && git commit -m "Initial commit" (optional) 4: npm run dev -- --open To close the dev server, hit Ctrl-C Stuck? Visit us at https://svelte.dev/chat ``` --------- Signed-off-by: Divy Srivastava <[email protected]>
Originally reported in #17248
During the implementation of
node:tty
we had to make a tradeoff whereintty.ReadStream
andtty.WriteStream
were made to extend aDuplex
instead of anet.Socket
because it introduced circular dependencies at snapshot-time. In Node.js, this problem is solved by using a require at runtime:The text was updated successfully, but these errors were encountered: