Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support @clack/core #20890

Closed
littledivy opened this issue Oct 12, 2023 · 0 comments · Fixed by #20892 or #21026
Closed

Support @clack/core #20890

littledivy opened this issue Oct 12, 2023 · 0 comments · Fixed by #20892 or #21026
Labels
bug Something isn't working correctly node compat

Comments

@littledivy
Copy link
Member

#20336 (comment)
This was referenced Oct 12, 2023
Closed
Merged
@littledivy littledivy added bug Something isn't working correctly node compat labels Oct 17, 2023
littledivy added a commit that referenced this issue Oct 30, 2023
@littledivy
fix: implement node:tty (#20892)
0920410 
Fixes #21012
Closes #20855
Fixes #20890
Fixes #20611
Fixes #20336
Fixes `create-svelte` from #17248

Fixes more reports here:
- #6529 (comment)
- #6529 (comment)
- #6529 (comment)
bartlomieju pushed a commit to bartlomieju/deno that referenced this issue Oct 30, 2023
@littledivy @bartlomieju
fix: implement node:tty (denoland#20892)
f62a652 
Fixes denoland#21012
Closes denoland#20855
Fixes denoland#20890
Fixes denoland#20611
Fixes denoland#20336
Fixes `create-svelte` from denoland#17248

Fixes more reports here:
- denoland#6529 (comment)
- denoland#6529 (comment)
- denoland#6529 (comment)
@benmccann benmccann mentioned this issue Oct 31, 2023
Closed
@littledivy littledivy reopened this Oct 31, 2023
@littledivy littledivy mentioned this issue Oct 31, 2023
Merged
littledivy added a commit that referenced this issue Oct 31, 2023
@littledivy
fix(ext/node): tty streams extends net socket (#21026)
f62e22a 
Workaround the circular references issue by using a initializer function
to give tty stream class to `initStdin`.

Fixes #21024
Fixes #20611
Fixes #20890
Fixes #20336

`create-svelte` works now:
```
divy@mini /t/a> ~/gh/deno/target/debug/deno run -A --unstable --reload npm:create-svelte@latest sveltekit-deno

create-svelte version 5.1.1

┌  Welcome to SvelteKit!
│
◇  Which Svelte app template?
│  Skeleton project
│
◇  Add type checking with TypeScript?
│  Yes, using JavaScript with JSDoc comments
│
◇  Select additional options (use arrow keys/space bar)
│  none
│
└  Your project is ready!

✔ Type-checked JavaScript
  https://www.typescriptlang.org/tsconfig#checkJs

Install community-maintained integrations:
  https://github.com/svelte-add/svelte-add

Next steps:
  1: cd sveltekit-deno
  2: npm install
  3: git init && git add -A && git commit -m "Initial commit" (optional)
  4: npm run dev -- --open

To close the dev server, hit Ctrl-C

Stuck? Visit us at https://svelte.dev/chat
```

---------

Signed-off-by: Divy Srivastava <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working correctly node compat
Projects
None yet
Milestone
No milestone
1 participant
@littledivy