Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Go 1.16 to the build matrix #648

Closed

Conversation

shogo82148
Copy link
Contributor

No description provided.

Comment on lines -40 to -41
GOVERSION: 115
SQLINSTANCE: SQL2017
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SQL2017 is already covered at

SQLINSTANCE: SQL2017

so I dropped this case.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I can see every matrix entry needs a SQLINSTANCE since there's no global setting 🤔

@shogo82148
Copy link
Contributor Author

The build fails due to #639
https://ci.appveyor.com/project/denisenkom/go-mssqldb/builds/38567703/job/mpadty14o33sx2re

panic: Not implemented [recovered]
	panic: Not implemented
goroutine 2183 [running]:
testing.tRunner.func1.2(0x64b360, 0x742b20)
	c:/go116/src/testing/testing.go:1144 +0x49f
testing.tRunner.func1(0xc000088480)
	c:/go116/src/testing/testing.go:1147 +0x695
panic(0x64b360, 0x742b20)
	c:/go116/src/runtime/panic.go:971 +0x49a
github.com/denisenkom/go-mssqldb.passthroughConn.SetWriteDeadline(...)
	C:/gopath/src/github.com/denisenkom/go-mssqldb/net.go:167
crypto/tls.(*Conn).SetWriteDeadline(...)
	c:/go116/src/crypto/tls/conn.go:150
(snip)

#642 maybe fix it.

@robinknaapen
Copy link
Contributor

I've added Go116 pipeline to #642

@denisenkom
Copy link
Owner

This is done in a different PR

@denisenkom denisenkom closed this Apr 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants