Workaround for Go 1.16 #642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #642 +/- ##
==========================================
+ Coverage 71.98% 72.31% +0.32%
==========================================
Files 24 24
Lines 5469 5469
==========================================
+ Hits 3937 3955 +18
+ Misses 1309 1289 -20
- Partials 223 225 +2
Continue to review full report at Codecov.
|
|
Any chance we could see this PR reviewed/merged soon? |
|
Hope to see this merged soon too. |
This was referenced Mar 28, 2021
|
Author's GitHub activity seems pretty poor. |
|
You mean mine, or @denisenkom's? |
Sorry, yes, the maintainer's, the author of the driver. That's the person we all waiting for. |
Closed
|
Any chance of a new release containing this fix? |
jsternberg
added a commit
to influxdata/flux
that referenced
this pull request
May 4, 2021
2 tasks
jsternberg
added a commit
to influxdata/flux
that referenced
this pull request
May 4, 2021
samfoxcode
added a commit
to samfoxcode/migrate
that referenced
this pull request
Jun 18, 2021
update go-mssqldb to resolve panic issue referenced here: denisenkom/go-mssqldb#642
dhui
pushed a commit
to golang-migrate/migrate
that referenced
this pull request
Jul 2, 2021
* MSI Auth for SQL Server Add MSI Auth option to SQL Server connection. Default if no password is provided in connection string. * Parse resource endpoint from server for msi update host name parsing to get just the resource endpoint for msi * Update go-mssqldb update go-mssqldb to resolve panic issue referenced here: denisenkom/go-mssqldb#642 * Update sqlserver.go switch from deprecated methods. NewServicePrincipalTokenFromManagedIdentity calls the two methods that are deprecated for us * Update sqlserver.go add useMsi param instead of looking for nil password * Update sqlserver readme Update sqlserver readme for msi auth. make useMsi a bit safer * Update sqlserver.go remove comment * Update database/sqlserver/README.md Co-authored-by: Keegan Campbell <[email protected]> * Update sqlserver.go refactor resource uri logic into its own method * Update sqlserver_test.go add tests for msi connection. can only test whether it fails with useMsi= true, or succeeds with useMsi=false * Update sqlserver.go check msi.EnsureFresh return value * Return error for multiple auth and move query filter move migrate.FilterCustomQuery(purl).String() into one line out of if/else. return error if both useMsi=true and password are passed * Update README.md update readme with warning for useMsi * Update sqlserver_test.go Update TestMsiFalse test case as now it should fail when useMsi=false and no password is provided Co-authored-by: Keegan Campbell <[email protected]>
szh
added a commit
to cyberark/go-mssqldb
that referenced
this pull request
Oct 29, 2021
szh
added a commit
to cyberark/go-mssqldb
that referenced
this pull request
Nov 1, 2021
Workaround based on denisenkom/pull/642
FPiety0521
pushed a commit
to FPiety0521/Golang-SQL
that referenced
this pull request
May 24, 2023
* MSI Auth for SQL Server Add MSI Auth option to SQL Server connection. Default if no password is provided in connection string. * Parse resource endpoint from server for msi update host name parsing to get just the resource endpoint for msi * Update go-mssqldb update go-mssqldb to resolve panic issue referenced here: denisenkom/go-mssqldb#642 * Update sqlserver.go switch from deprecated methods. NewServicePrincipalTokenFromManagedIdentity calls the two methods that are deprecated for us * Update sqlserver.go add useMsi param instead of looking for nil password * Update sqlserver readme Update sqlserver readme for msi auth. make useMsi a bit safer * Update sqlserver.go remove comment * Update database/sqlserver/README.md Co-authored-by: Keegan Campbell <[email protected]> * Update sqlserver.go refactor resource uri logic into its own method * Update sqlserver_test.go add tests for msi connection. can only test whether it fails with useMsi= true, or succeeds with useMsi=false * Update sqlserver.go check msi.EnsureFresh return value * Return error for multiple auth and move query filter move migrate.FilterCustomQuery(purl).String() into one line out of if/else. return error if both useMsi=true and password are passed * Update README.md update readme with warning for useMsi * Update sqlserver_test.go Update TestMsiFalse test case as now it should fail when useMsi=false and no password is provided Co-authored-by: Keegan Campbell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should workaround the issues regarding to the tls changes in Go 1.16.
This is by no means a proper fix
I do not have enough knowledge about the foundation of the tls package. I can only confirm that the changes fixed my issues.