improvement: better scroll for jumpToMessage #4286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WofWca
force-pushed
the
wofwca/fix-scroll-to-first-unread
branch
from
77098d7 to
49eac14
Compare
WofWca
force-pushed
the
wofwca/fix-scroll-to-first-unread
branch
from
49eac14 to
4fd1d57
Compare
nicodh
approved these changes
Oct 29, 2024
Simon-Laux
approved these changes
Oct 29, 2024
|
Let me rebase |
There are a lot of params, it's getting hard not to mix them up. And I want to add another one. I have dobule-checked that this commit doesn't mix up the arguments.
Follow-up to the previous commit.
Add `scrollIntoViewArg` parameter to `jumpToMessage` and specify different values for it depending on context. More specifically, prefer scrolling the target message to the center, e.g. when showing the first unread message. Prior to this commit, we'd scroll the first unread message such that it's at the bottom of the message list, which can be considered a regression, which was introduced in 5f0efe1. Closes #4284.
WofWca
force-pushed
the
wofwca/fix-scroll-to-first-unread
branch
from
4fd1d57 to
22aeadf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
scrollIntoViewArgparameter tojumpToMessageand specify different values for it depending on context.
More specifically, prefer scrolling the target message
to the center, e.g. when showing the first unread message.
Prior to this commit, we'd scroll the first unread message
such that it's at the bottom of the message list,
which can be considered a regression, which was introduced in
5f0efe1.
Closes #4284.
I recommend reviewing commit by commit.
TODO: