Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fresh messages: opening a chat only shows the first one, you need to scroll for the rest #4284

Closed
missytake opened this issue Oct 28, 2024 · 2 comments · Fixed by #4286
Closed

Fresh messages: opening a chat only shows the first one, you need to scroll for the rest #4284

missytake opened this issue Oct 28, 2024 · 2 comments · Fixed by #4286
Assignees
@WofWca
Labels
ui/ux UI/UX related issues

Comments

@missytake
Copy link
Contributor

  • Operating System (Linux/Mac/Windows/iOS/Android): xubuntu 22.04
  • Delta Chat Version: 1.47.0
  • Expected behavior: If I open a chat with multiple fresh messages, half of the chat view shows the fresh ones, half of the chat view old messages for context.
  • Actual behavior: If I open a chat with multiple fresh messages, the chat view only shows the first of them, and you need to scrolls down until you see the other fresh messages, even if they would span less than half of the screen.
  • Steps to reproduce the problem:
    • Alice sends to messages to Bob
    • in Bob's profile, open the chat with Alice and view the first message
    • now scrolls down to see the second message
@WofWca WofWca self-assigned this Oct 28, 2024
@WofWca WofWca added the ui/ux UI/UX related issues label Oct 28, 2024
@Simon-Laux
Copy link
Member

Simon-Laux commented Oct 28, 2024 •
edited
Loading

Ideally we would insert a visual new messages marker.
dc-iOS does this, but they have jumping around when it is removed after a scrolling and a few seconds (unless it was recently fixed, I don't know what android does). If we also remove the fresh messages indicator it should not jump around, one simple solution could maybe be to use negative margin to insert between messages? Or save scroll position, remove element, then restore it?

Edit: in the past there also was some core api that inserted a fresh message marker, but it was removed afaik. I think it's better (than modifying core api to re-add it) just use the api that is used to find that message when the chat is opened (or open chat with that position as argument so message list can insert the marker?)

@WofWca
Copy link
Collaborator

WofWca commented Oct 28, 2024

Removing it when it's out of view is another option.

WofWca added a commit that referenced this issue Oct 28, 2024
@WofWca
improvement: better scroll for jumpToMessage
77098d7 
Add `scrollIntoViewArg` parameter to `jumpToMessage`
and specify different values foe it depending on context.

More specifically, prefer scrolling the target message
to the center, e.g. when showing the first unread message.
Prior to this commit, we'd scroll the first unread message
such that it's at the bottom of the message list,
which can be considered a regression, which was introduced in
5f0efe1.

Closes #4284.
WofWca added a commit that referenced this issue Oct 28, 2024
@WofWca
improvement: better scroll for jumpToMessage
49eac14 
Add `scrollIntoViewArg` parameter to `jumpToMessage`
and specify different values foe it depending on context.

More specifically, prefer scrolling the target message
to the center, e.g. when showing the first unread message.
Prior to this commit, we'd scroll the first unread message
such that it's at the bottom of the message list,
which can be considered a regression, which was introduced in
5f0efe1.

Closes #4284.
@WofWca WofWca mentioned this issue Oct 28, 2024
Merged
1 task
WofWca added a commit that referenced this issue Oct 28, 2024
@WofWca
improvement: better scroll for jumpToMessage
4fd1d57 
Add `scrollIntoViewArg` parameter to `jumpToMessage`
and specify different values for it depending on context.

More specifically, prefer scrolling the target message
to the center, e.g. when showing the first unread message.
Prior to this commit, we'd scroll the first unread message
such that it's at the bottom of the message list,
which can be considered a regression, which was introduced in
5f0efe1.

Closes #4284.
WofWca added a commit that referenced this issue Oct 29, 2024
@WofWca
improvement: better scroll for jumpToMessage
22aeadf 
Add `scrollIntoViewArg` parameter to `jumpToMessage`
and specify different values for it depending on context.

More specifically, prefer scrolling the target message
to the center, e.g. when showing the first unread message.
Prior to this commit, we'd scroll the first unread message
such that it's at the bottom of the message list,
which can be considered a regression, which was introduced in
5f0efe1.

Closes #4284.
@WofWca WofWca closed this as completed in c28d796 Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@WofWca WofWca

Labels
ui/ux UI/UX related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

improvement: better scroll for jumpToMessage deltachat/deltachat-desktop
3 participants
@Simon-Laux @WofWca @missytake