Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct map field names #2182

Merged
merged 3 commits into from
Feb 14, 2024
Merged

fix: correct map field names #2182

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1429ba8
fix: correct map field names
emcake Feb 11, 2024
c13216a
test
emcake Feb 12, 2024
7cfa36a
Merge branch 'main' into fix-map-field-names
rtyler Feb 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions crates/core/src/kernel/arrow/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ pub(crate) mod extract;
pub(crate) mod json;

const MAP_ROOT_DEFAULT: &str = "entries";
const MAP_KEY_DEFAULT: &str = "keys";
const MAP_VALUE_DEFAULT: &str = "values";
const MAP_KEY_DEFAULT: &str = "key";
const MAP_VALUE_DEFAULT: &str = "value";
const LIST_ROOT_DEFAULT: &str = "item";

impl TryFrom<ActionType> for ArrowField {
Expand Down Expand Up @@ -846,9 +846,9 @@ mod tests {
let entry_offsets_buffer = Buffer::from(entry_offsets.to_byte_slice());
let keys_data = StringArray::from_iter_values(keys);

let keys_field = Arc::new(Field::new("keys", ArrowDataType::Utf8, false));
let keys_field = Arc::new(Field::new("key", ArrowDataType::Utf8, false));
let values_field = Arc::new(Field::new(
"values",
"value",
values.data_type().clone(),
values.null_count() > 0,
));
Expand Down
Loading