fix: correct map field names #2182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ion-elgreco
approved these changes
Feb 14, 2024
|
@emcake @ion-elgreco - sorry for being late to the discussion. Just to create awareness, bit there is no "right" wat for theses names -AFAIK. Different parquet writers and readers behave differently and different arrow implementations also take different positions on this. So "right" only applies to a given implementation. I habe some work queued to try and solve some of this more generally, but the changes in this Pr may not be quite long-lived depending on which implementation we will end up aligning with. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This changes the field names inside map types to be
keyandvalueinstead ofkeysandvalues. This matches the parquet spec for encoding map columns: https://github.com/apache/parquet-format/blob/master/LogicalTypes.md#mapsI found this while trying to load a checkpoint from a table where it was failing with spurious errors. Pyarrow is tolerant of this to a degree but other readers like parquet4s (used in e.g delta standalone) took issue with it.