-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add usage guide for check constraints #2079
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r3stl355
reviewed
Jan 14, 2024
docs/usage/constraints.md
Outdated
|
||
## Add the Constraint | ||
|
||
```python |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any chance you want to move new format, e.g. a quick example:
- https://github.com/delta-io/delta-rs/blob/main/docs/usage/index.md
- referring to function under in https://github.com/delta-io/delta-rs/blob/main/docs/src/python/delta_table.py and https://github.com/delta-io/delta-rs/blob/main/docs/src/rust/delta_table.rs
- in addition, if there is something in the API for more info then you can add those links here and refer in the example in md file: https://github.com/delta-io/delta-rs/blob/main/docs/_build/links.yml
Looks good |
MrPowers
previously approved these changes
Jan 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
MrPowers
previously approved these changes
Jan 15, 2024
MrPowers
approved these changes
Jan 16, 2024
RobinLin666
pushed a commit
to RobinLin666/delta-rs
that referenced
this pull request
Feb 2, 2024
# Description Added a usage guide for adding check constraints to tables # Related Issue(s) Closes delta-io#2063 # Documentation I just wrote it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a usage guide for adding check constraints to tables
Related Issue(s)
Closes #2063
Documentation
I just wrote it