Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MacOS arm64 wheels are generated incorrectly #972

Closed
hsheth2 opened this issue Nov 28, 2022 · 2 comments · Fixed by #976
Closed

MacOS arm64 wheels are generated incorrectly #972

hsheth2 opened this issue Nov 28, 2022 · 2 comments · Fixed by #976
Assignees
@fvaleye
Labels
bug Something isn't working

Comments

@hsheth2
Copy link

hsheth2 commented Nov 28, 2022 •
edited
Loading

Environment

Binding: Python

Environment:

  • OS: MacOS 13 (M1 / arm64)
  • Python 3.10.8
  • Pip 22.3.1

Bug

What happened:

On the PyPI releases page (https://pypi.org/project/deltalake/0.6.4/#files), the arm64 wheel file is published as deltalake-0.6.4-cp37-abi3-macosx_10_9_arm64.whl. However, it should be macosx_11_0_arm64.whl. This causes pip to not install from source instead of using the pre-built wheel.

What you expected to happen: Pip should install from wheel.

More details:

Note that pip -v debug does not contain macosx_10_9_arm64 but does contain macosx_11_0_arm64. As such, macosx_10_9_arm64 is never a compatible ABI tag. I believe the actions release workflow is not generating the correct ABI tag.

Release log: https://github.com/delta-io/delta-rs/actions/runs/3567491762/jobs/5995258547#step:3:668

Possible fixes

  1. build universal2 wheels on mac (not sure if this is actually possible for delta-rs)
  2. increase the min macosx version to 11_0 for the arm64 wheel.
@hsheth2 hsheth2 added the bug Something isn't working label Nov 28, 2022
@fvaleye fvaleye mentioned this issue Nov 29, 2022
Merged
@fvaleye
Copy link
Collaborator

fvaleye commented Nov 29, 2022 •
edited
Loading

Thank you @hsheth2 for reporting this issue 👍

I added a dedicated GitHub Action to release universal2 wheel on MacOS!

@fvaleye fvaleye self-assigned this Nov 29, 2022
fvaleye added a commit that referenced this issue Nov 29, 2022
@fvaleye
Add a new release github action for Python binding: macos with univer…
6e9c2b8 
…sal2 wheel (#976)

# Description
- Add a new Python binding release Github Action for `universal2` wheel
in PyPy
- Set version 1 for maturin-action

# Related Issue(s)
- closes #972 

# Documentation
- **universal2:**
This wheel contains both architectures, causing it to be up to twice the
size (data files do not get doubled, only compiled code). It requires
Pip 20.3 (Packaging 20.6+) to load on Intel, and Pip 21.0.1 (Packaging
20.9+) to load on Apple Silicon.
@hsheth2
Copy link
Author

hsheth2 commented Nov 29, 2022

@fvaleye thanks for the prompt fix!

@hsheth2 hsheth2 mentioned this issue Dec 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fvaleye fvaleye

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a new release github action for Python binding: macos with universal2 wheel fvaleye/delta-rs
2 participants
@hsheth2 @fvaleye