Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Developing on Metadata Ingestion docs missing Cargo requirement #5895

Closed
remisalmon opened this issue Sep 9, 2022 · 2 comments
Closed

Developing on Metadata Ingestion docs missing Cargo requirement #5895

remisalmon opened this issue Sep 9, 2022 · 2 comments
Labels
accepted An Issue that is confirmed as a bug by the DataHub Maintainers. docs Issues and Improvements to docs ingestion PR or Issue related to the ingestion of metadata

Comments

@remisalmon
Copy link
Contributor

Describe the bug

The Developing on Metadata Ingestion docs at https://datahubproject.io/docs/metadata-ingestion/developing are missing Cargo as a requirement.

To Reproduce
Steps to reproduce the behavior:

  1. Uninstall Cargo (if installed)
  2. Run gradlew :metadata-ingestion:installDev (from https://datahubproject.io/docs/metadata-ingestion/developing#set-up-your-python-environment)
  3. See error
  × Preparing metadata (pyproject.toml) did not run successfully.
  │ exit code: 1
  ╰─> [6 lines of output]

      Cargo, the Rust package manager, is not installed or is not on PATH.
      This package requires Rust and Cargo to compile extensions. Install it through
      the system's package manager or via https://rustup.rs/

      Checking for Rust toolchain....
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed

× Encountered error while generating package metadata.
╰─> See above for output.

note: This is an issue with the package mentioned above, not pip.
hint: See above for details.

> Task :metadata-ingestion:installDev FAILED

FAILURE: Build failed with an exception.

Expected behavior

Cargo should be listed as a requirement in https://datahubproject.io/docs/metadata-ingestion/developing#requirements

@remisalmon remisalmon added the bug Bug report label Sep 9, 2022
@remisalmon remisalmon changed the title Developing on Metadata Ingestion missing Cargo requirement Developing on Metadata Ingestion docs missing Cargo requirement Sep 9, 2022
@anshbansal anshbansal added docs Issues and Improvements to docs and removed bug Bug report labels Sep 13, 2022
@github-actions
Copy link

This issue is stale because it has been open for 30 days with no activity. If you believe this is still an issue on the latest DataHub release please leave a comment with the version that you tested it with. If this is a question/discussion please head to https://slack.datahubproject.io. For feature requests please use https://feature-requests.datahubproject.io

@github-actions github-actions bot added the stale label Oct 17, 2022
@shirshanka shirshanka added accepted An Issue that is confirmed as a bug by the DataHub Maintainers. ingestion PR or Issue related to the ingestion of metadata and removed stale labels Oct 31, 2022
@hsheth2
Copy link
Collaborator

hsheth2 commented Dec 6, 2022

I believe the root cause of this was delta-io/delta-rs#972, which has now been fixed (although it hasn't been released yet)

I'm closing this for now, but @remisalmon let me know if this issue is still present in a week and we can re-open it.

@hsheth2 hsheth2 closed this as completed Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted An Issue that is confirmed as a bug by the DataHub Maintainers. docs Issues and Improvements to docs ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Development

No branches or pull requests

4 participants