Optimize remove action apply with early iteration exit

[houqp]

Description

Use Case

Right now, we use Iterator::retain to remove files from active file list when applying remove actions from the transaction log:

delta-rs/rust/src/delta.rs

Line 1484 in 0a05cb4

state.files.retain(|a| *a.path != v.path);

This can be further optimized by performing an early exit of the iteration when we reach the file that needs to be removed. There is no point going through the remaining of the file list and compare paths since file paths should be unique.

Related Issue(s)

[akshay26031996]

Hey, can I have this issue? I am thinking of the following approach.

First find the position of the file to remove.

state.files.iter().position(|a| *a.path == v.path)

It will stop processing as soon as it finds a true.

Then we can just use the index from above to remove the element from files.

let index = { state.files.iter().position(|a| *a.path == v.path) };
if let Some(index) = index {
    state.files.remove(index);
}

[houqp]

Looks good to me, @akshay26031996 assigned the issue to you.