Optimize remove action apply with early iteration exit #424 #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dandandan
reviewed
Sep 17, 2021
rust/src/delta.rs
Outdated
| state.files.retain(|a| *a.path != v.path); | ||
| let index = { state.files.iter().position(|a| *a.path == v.path) }; | ||
| if let Some(index) = index { | ||
| state.files.remove(index); |
There was a problem hiding this comment.
As the order is not important (I believe) swap_remove could be used, which is O(1) instead of O(n)
There was a problem hiding this comment.
I also think that order does not matter (although I am new to this repo). I am pushing the suggested change and the required changes in test. In test, I am sorting the vectors before comparing.
There was a problem hiding this comment.
That's a nice optimization, good call @Dandandan :)
houqp
approved these changes
Sep 18, 2021
|
Thanks @akshay26031996 for your contribution. |
mosyp
reviewed
Sep 21, 2021
| @@ -15,14 +15,15 @@ async fn read_simple_table() { | |||
| assert_eq!(table.get_min_writer_version(), 2); | |||
| assert_eq!(table.get_min_reader_version(), 1); | |||
| assert_eq!( | |||
| table.get_files(), | |||
| table.get_files().sort(), | |||
There was a problem hiding this comment.
good catch, @akshay26031996 could you send a PR to correct the tests?
There was a problem hiding this comment.
Noted, let me go through this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Right now, we use
Iterator::retainto remove files from active file list when applying remove actions from the transaction log. This can be optimized by performing an early exit of the iteration when we reach the file that needs to be removed.Related Issue(s)