Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent units of time #2256

Closed
cmackenzie1 opened this issue Mar 6, 2024 · 0 comments · Fixed by #2260
Closed

Inconsistent units of time #2256

cmackenzie1 opened this issue Mar 6, 2024 · 0 comments · Fixed by #2260
Labels
bug Something isn't working

Comments

@cmackenzie1
Copy link
Contributor

Environment

Delta-rs version: latest

Binding: rust

Environment:

  • Cloud provider:
  • OS:
  • Other:

Bug

What happened:

Sometimes duration fields suffixed with _ms report time as milliseconds (expected), but other times they are reported as microseconds.

https://github.com/delta-io/delta-rs/blob/main/crates/core/src/operations/update.rs#L400

https://github.com/delta-io/delta-rs/blob/main/crates/core/src/operations/delete.rs#L204

What you expected to happen:

All fields using _ms should be in milliseconds.

_ms -> milliseconds
_us -> microseconds

How to reproduce it:

More details:

Microsecond granularity is likely not needed for any operations that traverse the network.
@cmackenzie1 cmackenzie1 added the bug Something isn't working label Mar 6, 2024
cmackenzie1 added a commit to cmackenzie1-contrib/delta-rs that referenced this issue Mar 7, 2024
@cmackenzie1
fix(delta-io#2256): use consistent units of time
83bd93d 
Update timing fields using the suffix `_ms` to be in milliseconds.

Doing a quick grep through the repo I only found a few instances of this in the delete.rs file.

Closes delta-io#2256
@cmackenzie1 cmackenzie1 mentioned this issue Mar 7, 2024
Merged
ion-elgreco pushed a commit to cmackenzie1-contrib/delta-rs that referenced this issue Mar 7, 2024
@cmackenzie1 @ion-elgreco
fix(delta-io#2256): use consistent units of time
83316ea 
Update timing fields using the suffix `_ms` to be in milliseconds.

Doing a quick grep through the repo I only found a few instances of this in the delete.rs file.

Closes delta-io#2256
ion-elgreco pushed a commit that referenced this issue Mar 7, 2024
@cmackenzie1
fix(#2256): use consistent units of time (#2260)
3e6a4d6 
# Description

Update timing fields using the suffix `_ms` to be in milliseconds.

Doing a quick grep through the repo I only found a few instances of this
in the delete.rs file.

# Related Issue(s)

Closes #2256

# Documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(#2256): use consistent units of time cmackenzie1-contrib/delta-rs
1 participant
@cmackenzie1