Skip to content

Commit

Permalink
fix(delta-io#2256): use consistent units of time
Browse files Browse the repository at this point in the history
Update timing fields using the suffix `_ms` to be in milliseconds.

Doing a quick grep through the repo I only found a few instances of this in the delete.rs file.

Closes delta-io#2256
  • Loading branch information
cmackenzie1 committed Mar 7, 2024
1 parent 7c1bc35 commit 83bd93d
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions crates/core/src/operations/delete.rs
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ async fn execute(

let scan_start = Instant::now();
let candidates = find_files(snapshot, log_store.clone(), &state, predicate.clone()).await?;
metrics.scan_time_ms = Instant::now().duration_since(scan_start).as_micros();
metrics.scan_time_ms = Instant::now().duration_since(scan_start).as_millis();

let predicate = predicate.unwrap_or(Expr::Literal(ScalarValue::Boolean(Some(true))));

Expand Down Expand Up @@ -249,7 +249,7 @@ async fn execute(
}))
}

metrics.execution_time_ms = Instant::now().duration_since(exec_start).as_micros();
metrics.execution_time_ms = Instant::now().duration_since(exec_start).as_millis();

let mut app_metadata = match app_metadata {
Some(meta) => meta,
Expand Down

0 comments on commit 83bd93d

Please sign in to comment.