-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add constructor for Tablechanges
to get a CDF scan
#459
base: main
Are you sure you want to change the base?
Changes from all commits
c7913dc
6b331ac
f1f9886
8122113
46185ae
471a858
4ac35da
6297805
e569719
5edf4db
0b8463a
5300a7b
81d0de0
6b85932
1384ea3
0182326
d053a77
52f57e5
aa6c9f4
dca491c
bf5cdd4
748bab9
2a6eb3e
841f17f
1ce29d8
a2f9810
5f7a680
6d8e35f
ea7029a
9464d4e
f320416
ecd6cd7
585c663
b2af9e6
6e814cf
412f551
1a6a630
de206c7
298c70c
3a043b0
759f537
42896ec
c558715
44db9ea
ab672e6
6241ed1
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,7 +6,7 @@ use std::{ | |
str::Utf8Error, | ||
}; | ||
|
||
use crate::schema::DataType; | ||
use crate::{schema::DataType, Version}; | ||
|
||
/// A [`std::result::Result`] that has the kernel [`Error`] as the error variant | ||
pub type DeltaResult<T, E = Error> = std::result::Result<T, E>; | ||
|
@@ -171,6 +171,9 @@ pub enum Error { | |
/// The file already exists at the path, prohibiting a non-overwrite write | ||
#[error("File already exists: {0}")] | ||
FileAlreadyExists(String), | ||
|
||
#[error("Change data feed is disabled in range: {0} to {}", _1.map_or("end".into(), |ver| ver.to_string()))] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This error message has some confusing syntax, but I think we should clarify here. The error is not because it's disabled in the range (or the entire range perhaps), there is nothing wrong with doing that but that CDF doesn't allow you to disable it anywhere in the range and still work. |
||
TableChangesDisabled(Version, Option<Version>), | ||
} | ||
|
||
// Convenience constructors for Error types that take a String argument | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume when we're ready to go here this allow won't be needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, I'll go ahead and add a comment