Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Add constructor for Tablechanges to get a CDF scan #459

Draft
wants to merge 46 commits into
base: main
Choose a base branch
from
Draft

[WIP] Add constructor for Tablechanges to get a CDF scan #459

wants to merge 46 commits into from
+753 −429

Commits on Oct 28, 2024

  1. Move log segment into separate module 

    Log segment is going to be used by both snapshot and table changes.
It makes sense to separate it into its own module
    @OussamaSaoudi-db
    OussamaSaoudi-db committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    c7913dc View commit details
    Browse the repository at this point in the history

  2. Fix tests, make fields pub

    @OussamaSaoudi-db
    OussamaSaoudi-db committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    6b331ac View commit details
    Browse the repository at this point in the history

  3. Improve comments

    @OussamaSaoudi-db
    OussamaSaoudi-db committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    f1f9886 View commit details
    Browse the repository at this point in the history

  4. Remove table changes

    @OussamaSaoudi-db
    OussamaSaoudi-db committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    8122113 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into snapshot_cleanup

    @OussamaSaoudi-db
    OussamaSaoudi-db authored Oct 28, 2024
    Configuration menu
    Copy the full SHA
    46185ae View commit details
    Browse the repository at this point in the history

  6. change visibility

    @OussamaSaoudi-db
    OussamaSaoudi-db committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    471a858 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2024

  1. Merge branch 'main' into snapshot_cleanup

    @OussamaSaoudi-db
    OussamaSaoudi-db authored Nov 6, 2024
    Configuration menu
    Copy the full SHA
    4ac35da View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into snapshot_cleanup

    @OussamaSaoudi-db
    OussamaSaoudi-db committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    6297805 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'refs/remotes/origin/snapshot_cleanup' i… 

    …nto snapshot_cleanup
    @OussamaSaoudi-db
    OussamaSaoudi-db committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    e569719 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into snapshot_cleanup

    @OussamaSaoudi-db
    OussamaSaoudi-db committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    5edf4db View commit details
    Browse the repository at this point in the history

  5. Remove old log segment

    @OussamaSaoudi-db
    OussamaSaoudi-db committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    0b8463a View commit details
    Browse the repository at this point in the history

  6. fix failing tests

    @OussamaSaoudi-db
    OussamaSaoudi-db committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    5300a7b View commit details
    Browse the repository at this point in the history

  7. Get rid of warnings

    @OussamaSaoudi-db
    OussamaSaoudi-db committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    81d0de0 View commit details
    Browse the repository at this point in the history

  8. Fix failing tests

    @OussamaSaoudi-db
    OussamaSaoudi-db committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    6b85932 View commit details
    Browse the repository at this point in the history

  9. Apply suggestions from code review 

    Co-authored-by: Ryan Johnson <[email protected]>
    @OussamaSaoudi-db @scovich
    OussamaSaoudi-db and scovich authored Nov 6, 2024
    Configuration menu
    Copy the full SHA
    1384ea3 View commit details
    Browse the repository at this point in the history

  10. Address more pr comments

    @OussamaSaoudi-db
    OussamaSaoudi-db committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    0182326 View commit details
    Browse the repository at this point in the history

  11. fix imports

    @OussamaSaoudi-db
    OussamaSaoudi-db committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    d053a77 View commit details
    Browse the repository at this point in the history

  12. rebase onto git changes

    @OussamaSaoudi-db
    OussamaSaoudi-db committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    52f57e5 View commit details
    Browse the repository at this point in the history

  13. address nits

    @OussamaSaoudi-db
    OussamaSaoudi-db committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    aa6c9f4 View commit details
    Browse the repository at this point in the history

  14. fix visibility issue

    @OussamaSaoudi-db
    OussamaSaoudi-db committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    dca491c View commit details
    Browse the repository at this point in the history

  15. Use LogSegmentBuilder

    @OussamaSaoudi-db
    OussamaSaoudi-db committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    bf5cdd4 View commit details
    Browse the repository at this point in the history

  16. Introduce start and end versions

    @OussamaSaoudi-db
    OussamaSaoudi-db committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    748bab9 View commit details
    Browse the repository at this point in the history

  17. Remove old code

    @OussamaSaoudi-db
    OussamaSaoudi-db committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    2a6eb3e View commit details
    Browse the repository at this point in the history

  18. Fix failing tests

    @OussamaSaoudi-db
    OussamaSaoudi-db committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    841f17f View commit details
    Browse the repository at this point in the history

  19. Most up to date logsegment

    @OussamaSaoudi-db
    OussamaSaoudi-db committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    1ce29d8 View commit details
    Browse the repository at this point in the history

  20. Fix failing test and remove unnecessary code

    @OussamaSaoudi-db
    OussamaSaoudi-db committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    a2f9810 View commit details
    Browse the repository at this point in the history

  21. remove table changes from this commit

    @OussamaSaoudi-db
    OussamaSaoudi-db committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    5f7a680 View commit details
    Browse the repository at this point in the history

  22. remove table_changes

    @OussamaSaoudi-db
    OussamaSaoudi-db committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    6d8e35f View commit details
    Browse the repository at this point in the history

  23. Fix failing tests

    @OussamaSaoudi-db
    OussamaSaoudi-db committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    ea7029a View commit details
    Browse the repository at this point in the history

  24. Basic Table Changes construction

    @OussamaSaoudi-db
    OussamaSaoudi-db committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    9464d4e View commit details
    Browse the repository at this point in the history

  25. Add beginning of the Scannable trait

    @OussamaSaoudi-db
    OussamaSaoudi-db committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    f320416 View commit details
    Browse the repository at this point in the history

  26. table_changes constructor

    @OussamaSaoudi-db
    OussamaSaoudi-db committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    ecd6cd7 View commit details
    Browse the repository at this point in the history

  27. Revert "Add beginning of the Scannable trait" 

    This reverts commit 470446b.
    @OussamaSaoudi-db
    OussamaSaoudi-db committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    585c663 View commit details
    Browse the repository at this point in the history

  28. Constructor

    @OussamaSaoudi-db
    OussamaSaoudi-db committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    b2af9e6 View commit details
    Browse the repository at this point in the history

  29. TableCHangesScan copied from Scan

    @OussamaSaoudi-db
    OussamaSaoudi-db committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    6e814cf View commit details
    Browse the repository at this point in the history

  30. CHange log segment builder's names

    @OussamaSaoudi-db
    OussamaSaoudi-db committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    412f551 View commit details
    Browse the repository at this point in the history

  31. Basic iteration for CDF

    @OussamaSaoudi-db
    OussamaSaoudi-db committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    1a6a630 View commit details
    Browse the repository at this point in the history

  32. Read path until scanfile

    @OussamaSaoudi-db
    OussamaSaoudi-db committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    de206c7 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2024

  1. Remove non-constructor code

    @OussamaSaoudi-db
    OussamaSaoudi-db committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    298c70c View commit details
    Browse the repository at this point in the history

  2. Remove change_data testing file

    @OussamaSaoudi-db
    OussamaSaoudi-db committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    3a043b0 View commit details
    Browse the repository at this point in the history

  3. Remove unnecessary changes

    @OussamaSaoudi-db
    OussamaSaoudi-db committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    759f537 View commit details
    Browse the repository at this point in the history

  4. Fix comments

    @OussamaSaoudi-db
    OussamaSaoudi-db committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    42896ec View commit details
    Browse the repository at this point in the history

  5. Add preliminary test for table changes

    @OussamaSaoudi-db
    OussamaSaoudi-db committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    c558715 View commit details
    Browse the repository at this point in the history

  6. fix failing test

    @OussamaSaoudi-db
    OussamaSaoudi-db committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    44db9ea View commit details
    Browse the repository at this point in the history

  7. Add test for valid and invalid cdf ranges

    @OussamaSaoudi-db
    OussamaSaoudi-db committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    ab672e6 View commit details
    Browse the repository at this point in the history

  8. address pr comments

    @OussamaSaoudi-db
    OussamaSaoudi-db committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    6241ed1 View commit details
    Browse the repository at this point in the history