Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Append always the role name in the role binding name #988

Merged
merged 1 commit into from
May 24, 2022

Conversation

Sgitario
Copy link
Collaborator

Also, do not use the labels if the first deployment resource is found (as it could be an additional resource, not the generated one from Dekorate).

Fix #987

Also, do not use the labels if the first deployment resource is found (as it could be an additional resource, not the generated one from Dekorate).
@Sgitario Sgitario requested a review from iocanel May 24, 2022 09:18
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@iocanel iocanel merged commit c1bc23f into dekorateio:main May 24, 2022
@Sgitario Sgitario deleted the fix_role_binding_dekorator branch May 24, 2022 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logic to set the name in the Kubernetes Role Binding Dekorate is not correct
2 participants