Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logic to set the name in the Kubernetes Role Binding Dekorate is not correct #987

Closed
Sgitario opened this issue May 24, 2022 · 0 comments · Fixed by #988
Closed

Logic to set the name in the Kubernetes Role Binding Dekorate is not correct #987

Sgitario opened this issue May 24, 2022 · 0 comments · Fixed by #988
Assignees

Comments

@Sgitario
Copy link
Collaborator

Sgitario commented May 24, 2022

There are two issues in regards to the AddRoleBindingResourceDecorator:

  1. We can't set a role binding name like "myname-view", because the logic checks that at least one deployment with the same name exists.
  2. If we do not set any role binding name, it will use the name of the first deployment resource found. So, if we provide custom resource that adds at least one additional deployment (for example, with the name "myotherdeployment", the role binding name will use this deployment name plus the role name, which is not consistent with the behavior when not adding custom resources.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant