fix: correct fsGroup configuration in various deployments #974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for leapfrogai-docs canceled.
|
justinthelaw
reviewed
Sep 3, 2024
There was a problem hiding this comment.
Awesome! I also [will have] fixed this here. This works locally, I but am not sure if this actually helps in a CSP deployment as well (as in, I am literally not sure and haven't tried it myself yet).
Have you tested this in an EC2-based cluster using EFS yet?
justinthelaw
approved these changes
Sep 3, 2024
Yes! We replicated and validated this fix on an RKE2 cluster (running on an EC2 instance) that was using |
CollectiveUnicorn
approved these changes
Sep 3, 2024
|
These changes all make sense and I didn't see any issues when redeploying. |
This was
linked to
issues
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several (if not all 😬) of our deployments had the
fsGroupconfiguration in the wrong place so it wasn't actually applying. This led to an issue where our data-injections were not working when the underlying store was not a PVC provisioned withlocal-pathas the StorageClass.This PR fixes the fsGroup key so that it is in the correct place.