-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: add containerization and packaging manifest lints #937
Conversation
✅ Deploy Preview for leapfrogai-docs canceled.
|
Instead of using an outdated and/or sketchy helm-lint action use this to manually install helm v3.15.1 and manually perform a |
Blocked by #920 |
42ffbd5
to
fac06e9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome job cleaning things up!
some awesome cleanup, ty justin. I didn't review the code closely, but thanks for giving the thorough changelog. This is all great stuff in making the "ux" of contributing and deploying lfai better |
All changes completed and explanations reviewed by others
Merge this one in first: #977 Then merge with main and change e2e registry1 weekly to point to the commit SHA as a result of the above merge. |
Description
Adds linting for Helm, Docker, Zarf, and UDS manifests to improve the quality and consistency of all containerization and Kubernetes related logic.
Adds workflows and pre-commits to ensure consistency before and after committing to a PR.
Remaining lower-priority Dockerfile lint errors are in issue #984
BREAKING CHANGES
GPU_CLASS_NAME
is nowGPU_RUNTIME
to better align with the actual manifest spec field and purposeCHANGES
upstream-values.yaml
)v0.14.0
values.yaml
with default values, for UDS overrides following UDS Core patternsenv
variables to values filesGPU_ENABLED
python code/env from llama-cpp-pythonGPU_ENABLED
via values nor Zarf variables0
anyway, with no kosher way to change ite2e_registry1_weekly
test on draft PRs (mostly to stop it from running here all the time)check-merge-conflict
pre-commitclean
Make target for build artifact cleaning0.12.2
Related Issue
Fixes #965 #706 #705 #367 #365
Checklist before merging