Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify nightly failures #577

Merged
merged 17 commits into from
Mar 13, 2024
Merged

Notify nightly failures #577

merged 17 commits into from
Mar 13, 2024

Conversation

anakin87
Copy link
Member

@anakin87 anakin87 commented Mar 13, 2024

Part of #486
Based on #574. Do not merge before the base has been merged.

As discussed, I added a notification step to each integration workflow:
if the test is a nightly run (== is scheduled) and fails, a corresponding event is sent to Datadog, which then takes care of notifications using a specifically configured Monitor.

To reduce duplication, I created a composite action to send events to Datadog.
As you may have noticed, I ran several manual tests.

@anakin87 anakin87 changed the base branch from main to separate-unit-integration-tests March 13, 2024 08:22
@anakin87 anakin87 requested a review from masci March 13, 2024 12:09
@anakin87 anakin87 marked this pull request as ready for review March 13, 2024 12:09
@anakin87 anakin87 requested a review from a team as a code owner March 13, 2024 12:09
@anakin87 anakin87 requested review from silvanocerza and removed request for a team and silvanocerza March 13, 2024 12:09
Base automatically changed from separate-unit-integration-tests to main March 13, 2024 12:35
Copy link
Contributor

@masci masci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🚢

@anakin87 anakin87 merged commit b8f5e60 into main Mar 13, 2024
128 checks passed
@anakin87 anakin87 deleted the notify-nightly-failures branch March 13, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment