Refactor tests #574
Merged
Refactor tests #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anakin87
requested review from
silvanocerza
and removed request for
a team and
silvanocerza
anakin87
commented
Mar 12, 2024
| @@ -35,6 +35,7 @@ | |||
| ) | |||
|
|
|||
|
|
|||
| @pytest.mark.integration | |||
There was a problem hiding this comment.
not all the following tests are integration tests, but I chose not to interfere much with Weaviate, since it is a work in progress.
Merged
masci
approved these changes
Mar 13, 2024
github-actions
bot
added
the
type:documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To properly address #435,
it is best to completely separate unit tests from integration tests.
This PR attempts to do that, resulting in:
pytest.mark.unitpytest.mark.integrationwhere neededI was able to run all unit tests (not marked with
pytest.mark.integration) locally, without API keys set and containers running.