Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[r1.2] Fix typo: CMAKE_COMPILER_IS_GNUCXX #1040

Merged
merged 1 commit into from
Aug 26, 2021

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Aug 26, 2021

Cherry picked from #1038.


The flag won't work without language specified.
See https://cmake.org/cmake/help/v3.4/variable/CMAKE_COMPILER_IS_GNULANG.html

(cherry picked from commit 8bbe565)

@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2021

Codecov Report

❗ No coverage uploaded for pull request base (r1.2@69df1d2). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 8bbe565 differs from pull request most recent head 09a6ac1. Consider uploading reports for the commit 09a6ac1 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             r1.2    #1040   +/-   ##
=======================================
  Coverage        ?   82.90%           
=======================================
  Files           ?      120           
  Lines           ?    10127           
  Branches        ?        0           
=======================================
  Hits            ?     8396           
  Misses          ?     1731           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69df1d2...09a6ac1. Read the comment docs.

@njzjz njzjz changed the title [r1.2]Fix typo: CMAKE_COMPILER_IS_GNUCXX [r1.2] Fix typo: CMAKE_COMPILER_IS_GNUCXX Aug 26, 2021
@njzjz njzjz added this to the v1.2.5 milestone Aug 26, 2021
@amcadmus amcadmus merged commit b54b0ef into deepmodeling:r1.2 Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants