Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo: CMAKE_COMPILER_IS_GNUCXX #1038

Merged
merged 1 commit into from
Aug 26, 2021
Merged

Conversation

caic99
Copy link
Member

@caic99 caic99 commented Aug 26, 2021

@codecov-commenter
Copy link

Codecov Report

Merging #1038 (c613427) into devel (ed20998) will decrease coverage by 10.80%.
The diff coverage is n/a.

❗ Current head c613427 differs from pull request most recent head cb48952. Consider uploading reports for the commit cb48952 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##            devel    #1038       +/-   ##
===========================================
- Coverage   75.09%   64.28%   -10.81%     
===========================================
  Files          87        5       -82     
  Lines        6941       14     -6927     
===========================================
- Hits         5212        9     -5203     
+ Misses       1729        5     -1724     
Impacted Files Coverage Δ
deepmd/descriptor/hybrid.py
deepmd/utils/data.py
deepmd/utils/type_embed.py
deepmd/utils/weight_avg.py
deepmd/__init__.py
deepmd/descriptor/se_ar.py
deepmd/descriptor/se_r.py
source/op/_prod_force_se_r_grad.py
deepmd/infer/deep_eval.py
deepmd/cluster/__init__.py
... and 72 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed20998...cb48952. Read the comment docs.

@njzjz
Copy link
Member

njzjz commented Aug 26, 2021

I am wondering if we need CMAKE_LINK_WHAT_YOU_USE any more, as it seems that nothing is broken. @denghuilu what do you think?

@denghuilu
Copy link
Member

denghuilu commented Aug 26, 2021

I am wondering if we need CMAKE_LINK_WHAT_YOU_USE any more, as it seems that nothing is broken. @denghuilu what do you think?

@njzjz This typo could cause a miss link of LIB_DEEPMD_OP while compiling the LAMMPS executable file in my local workstation. This PR should fix the problem, thanks for the help of @caic99 .

@amcadmus amcadmus merged commit 8bbe565 into deepmodeling:devel Aug 26, 2021
@njzjz
Copy link
Member

njzjz commented Aug 26, 2021

I think we need to patch 8bbe565 to r1.2 and r1.3.

njzjz pushed a commit to njzjz/deepmd-kit that referenced this pull request Aug 26, 2021
njzjz pushed a commit to njzjz/deepmd-kit that referenced this pull request Aug 26, 2021
amcadmus pushed a commit that referenced this pull request Aug 26, 2021
The flag won't work without language specified.
See https://cmake.org/cmake/help/v3.4/variable/CMAKE_COMPILER_IS_GNULANG.html

(cherry picked from commit 8bbe565)

Co-authored-by: Chun Cai <[email protected]>
amcadmus pushed a commit that referenced this pull request Aug 26, 2021
The flag won't work without language specified.
See https://cmake.org/cmake/help/v3.4/variable/CMAKE_COMPILER_IS_GNULANG.html

(cherry picked from commit 8bbe565)

Co-authored-by: Chun Cai <[email protected]>
gzq942560379 pushed a commit to HPC-AI-Team/deepmd-kit that referenced this pull request Sep 2, 2021
gzq942560379 pushed a commit to HPC-AI-Team/deepmd-kit that referenced this pull request Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants