-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typo: CMAKE_COMPILER_IS_GNUCXX #1038
Conversation
The flag won't work without language specified. See https://cmake.org/cmake/help/v3.4/variable/CMAKE_COMPILER_IS_GNULANG.html
Codecov Report
@@ Coverage Diff @@
## devel #1038 +/- ##
===========================================
- Coverage 75.09% 64.28% -10.81%
===========================================
Files 87 5 -82
Lines 6941 14 -6927
===========================================
- Hits 5212 9 -5203
+ Misses 1729 5 -1724 Continue to review full report at Codecov.
|
I am wondering if we need |
@njzjz This typo could cause a miss link of LIB_DEEPMD_OP while compiling the LAMMPS executable file in my local workstation. This PR should fix the problem, thanks for the help of @caic99 . |
I think we need to patch 8bbe565 to |
The flag won't work without language specified. See https://cmake.org/cmake/help/v3.4/variable/CMAKE_COMPILER_IS_GNULANG.html (cherry picked from commit 8bbe565)
The flag won't work without language specified. See https://cmake.org/cmake/help/v3.4/variable/CMAKE_COMPILER_IS_GNULANG.html (cherry picked from commit 8bbe565)
The flag won't work without language specified. See https://cmake.org/cmake/help/v3.4/variable/CMAKE_COMPILER_IS_GNULANG.html (cherry picked from commit 8bbe565) Co-authored-by: Chun Cai <[email protected]>
The flag won't work without language specified. See https://cmake.org/cmake/help/v3.4/variable/CMAKE_COMPILER_IS_GNULANG.html (cherry picked from commit 8bbe565) Co-authored-by: Chun Cai <[email protected]>
The flag won't work without language specified. See https://cmake.org/cmake/help/v3.4/variable/CMAKE_COMPILER_IS_GNULANG.html
…1041) The flag won't work without language specified. See https://cmake.org/cmake/help/v3.4/variable/CMAKE_COMPILER_IS_GNULANG.html (cherry picked from commit 8bbe565) Co-authored-by: Chun Cai <[email protected]>
The flag won't work without language specified.
See https://cmake.org/cmake/help/v3.4/variable/CMAKE_COMPILER_IS_GNULANG.html, https://cmake.org/cmake/help/latest/variable/CMAKE_COMPILER_IS_GNUCXX.html