fix: Version bump + loading spinner fixes #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmingles
force-pushed
the
241-version-bump-and-fixes
branch
from
45175f6 to
f3188ae
Compare
bmingles
changed the title
mattrunyon
requested changes
Feb 5, 2024
bmingles
force-pushed
the
241-version-bump-and-fixes
branch
2 times, most recently
from
84a3a66 to
2060b75
Compare
mattrunyon
approved these changes
Feb 7, 2024
bmingles
force-pushed
the
241-version-bump-and-fixes
branch
from
72ea0d1 to
1c6f0ef
Compare
bmingles
force-pushed
the
241-version-bump-and-fixes
branch
from
1c6f0ef to
c97240a
Compare
mattrunyon
previously approved these changes
Feb 7, 2024
mattrunyon
approved these changes
Feb 7, 2024
bmingles
added a commit
to deephaven/web-client-ui
that referenced
this pull request
Feb 13, 2024
This PR - Move theme colors down to `layout.template.layout` so that they are used as defaults. Some of the theme colors had to be set in `layout.template.data` for specific trace types - Chart component now responds to ChartTheme context changes (this should enable chart theme switching, but it depends on some follow up plugins repo work to complete it). **Testing** For now, we should just make sure charts behave as they did before. Not all charts will update in response to a theme change, but re-running queries should show the theme change. I have tested this and have not seen any changes to existing behavior introduced by this PR Once the following plugins repo PRs have merged, the chart should fully respond to theme changes: deephaven/deephaven-plugins#243 deephaven/deephaven-plugins#251 resolves #1728 BREAKING CHANGE: - Renamed `ColorUtils.getColorwayFromTheme` to `normalizeColorway` - Removed `chartTheme` arg from functions in `ChartUtils`, `ChartModelFactory` and `FigureChartModel` in @deephaven/chart
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #241