Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinite loading spinner when upgrading plotly express DH dependencies to 0.60.0 #241

Closed
bmingles opened this issue Jan 30, 2024 · 0 comments · Fixed by #243
Closed

Infinite loading spinner when upgrading plotly express DH dependencies to 0.60.0 #241

bmingles opened this issue Jan 30, 2024 · 0 comments · Fixed by #243
Assignees
Labels
bug Something isn't working
Milestone

Comments

@bmingles
Copy link
Contributor

Description

Upgrading Plotly express plugin dependencies to DH 0.60.0 causes the loading spinner to never go away.

Steps to reproduce

  • Upgrade dh dependencies to 0.60.0 in plugins/plotly-express/src/js/package.json
  • Run the plugins repo locally via npm start
  • Configure proxy port VITE_JS_PLUGINS_DEV_PORT=4100 in DHC packages/code-studio/.env.development.local
  • Run the following code:
from deephaven import empty_table
import deephaven.plot.express as dx

y = ['A', 'B', 'C', 'D', 'E', 'F', 'G', 'H', 'I', 'J', 'K']

data = map(
    lambda x,i: f"{x}=X*EvenOdd+{i * 20}",
    y,
    range(len(y)))

t = empty_table(100).update([
    "X=ii",
    "EvenOdd = X % 2 / 4",
    ] + list(data))

p1 = dx.line(t, x="X", y=y)

Expected results

Loading spinner on chart should go away after data is loaded

Actual results

Loading spinner stays forever

Additional details and attachments

This seems to have been introduced by https://github.com/deephaven/web-client-ui/pull/1729/files , but the underlying issue seems to be we are never firing the EVENT_LOADFINISHED event from plotly express.

Versions

Web UI Version: 0.60.0

@bmingles bmingles added bug Something isn't working triage labels Jan 30, 2024
@bmingles bmingles self-assigned this Jan 30, 2024
@bmingles bmingles changed the title fix: Ininite loading spinner when upgrading plotly express DH dependencies to 0.60.0 Infinite loading spinner when upgrading plotly express DH dependencies to 0.60.0 Jan 30, 2024
bmingles added a commit to bmingles/deephaven-plugins that referenced this issue Jan 30, 2024
bmingles added a commit to bmingles/deephaven-plugins that referenced this issue Feb 5, 2024
bmingles added a commit to bmingles/deephaven-plugins that referenced this issue Feb 5, 2024
@vbabich vbabich removed the triage label Feb 6, 2024
@vbabich vbabich added this to the February 2024 milestone Feb 6, 2024
bmingles added a commit to bmingles/deephaven-plugins that referenced this issue Feb 6, 2024
bmingles added a commit to bmingles/deephaven-plugins that referenced this issue Feb 6, 2024
bmingles added a commit to bmingles/deephaven-plugins that referenced this issue Feb 7, 2024
bmingles added a commit to bmingles/deephaven-plugins that referenced this issue Feb 7, 2024
bmingles added a commit to bmingles/deephaven-plugins that referenced this issue Feb 7, 2024
bmingles added a commit to bmingles/deephaven-plugins that referenced this issue Feb 7, 2024
bmingles added a commit to bmingles/deephaven-plugins that referenced this issue Feb 7, 2024
bmingles added a commit to bmingles/deephaven-plugins that referenced this issue Feb 7, 2024
bmingles added a commit to bmingles/deephaven-plugins that referenced this issue Feb 7, 2024
bmingles added a commit that referenced this issue Feb 7, 2024
- DHC version bump
- Fixed infinite loading spinner
 
fixes #241
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants