fix: UI loading duplicate panels in embed iframe #1043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgodinez-dh
previously approved these changes
Nov 26, 2024
dgodinez-dh
approved these changes
Nov 26, 2024
mofojed
pushed a commit
to mofojed/deephaven-plugins
that referenced
this pull request
Jan 13, 2025
Fixes deephaven#1039 and adds some e2e tests
mofojed
added a commit
that referenced
this pull request
Jan 13, 2025
- Fixes #1039 and adds some e2e tests - Cherry-picking from #1043 to the ui-v0.23 branch --------- Co-authored-by: Matthew Runyon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1039 and adds some e2e tests
The default document for
WidgetHandlerto make a loader show up instantly meant in cases where the child was not wrapped byui.panel, we were wrapping in aReactPanelwith a key. That was the only key being set, so it would re-mount instead of re-use the panel opened for the loader. In embed-widget, panels are not closeable, so it did not close the loader panel.