-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deephaven.ui widgets in iframes open multiple panels #1039
Labels
bug
Something isn't working
Comments
Investigated this a bit. It seems to be due to the panels in embed-widget being not closeable (which we did on purpose so you can't get into unrecoverable states). We could make panels closeable (would be needed if you had conditional rendering of panels anyway). Should also figure out why embed-widget is not re-using the panel like code-studio appears to be. |
mattrunyon
added a commit
that referenced
this issue
Nov 26, 2024
Fixes #1039 and adds some e2e tests
mofojed
pushed a commit
to mofojed/deephaven-plugins
that referenced
this issue
Jan 13, 2025
Fixes deephaven#1039 and adds some e2e tests
mofojed
added a commit
that referenced
this issue
Jan 13, 2025
- Fixes #1039 and adds some e2e tests - Cherry-picking from #1043 to the ui-v0.23 branch --------- Co-authored-by: Matthew Runyon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
When opening a deephaven.ui widget from the iframe/widget link, it opens up two panels unnecessarily.
Steps to reproduce
Expected results
2. Widget should appear, no panel tabs because it's just one component.
Actual results
2. Widget appears but there are two panel tabs. The one panel tab is empty.
Additional details and attachments
I believe this is caused by @mattrunyon 's changes for #1023.
It is not present in the commit prior.
Versions
Engine Version: 0.37.0
Web UI Version: 0.99.0
Python Version: 3.12.3
Java Version: 11.0.25
Groovy Version: 3.0.22
Barrage Version: 0.7.2
Browser Name: Chrome 130
User Agent OS: Linux
@deephaven/js-plugin-plotly-express: 0.12.0
@deephaven/js-plugin-ui: 0.23.1
The text was updated successfully, but these errors were encountered: