fix: Identity error on billing change modal

[victorgcramos]

Closes #2656.

Fixes Identity error message on Set Billing Status modal.

UI Changes

Before:

After:

[lukebp]

This is suppose to use the global identity error that was added in #2623.

[victorgcramos]

Hmm okay, I thought the issue was with the message, not the error handling. Got it! Fixing it.

[lukebp]

This is working correctly if the user does not have an identity loaded in the browser at all, but is not working for when the user has the wrong identity loaded in the browser.

You can reproduce this by logging in using pictl and updating the user's identity with the pictl userupdatekey command. The identity saved to the browser will then be incorrect.

[tiagoalvesdulce]

This code works. But the error is outside the modal and the only way I can leave the Error page is returning to the Home page.

I think this is not the greatest UX. Can we keep the error inside the Modal? I'm not sure if ErrorBoundaries work with React Portal so the ideal solution might not be using them.

[tiagoalvesdulce]

Approved before by mistake.

[victorgcramos]

@tiagoalvesdulce this was defined on #2623. Maybe it's outside the pr scope... Let's open an issue and discuss better solutions for it, what do you think?

[tiagoalvesdulce]

oh, forgot about #2623. I'm fine with it but I think we should improve that in the next release. What do you think @lukebp ?

[lukebp]

Let's use the global error for now so that we can get the release pushed then open an issue for further improving this UX.

[lukebp]

tACK

[tiagoalvesdulce]

LGTM. @victorgcramos please create the issue so we don't forget to improve it.