Improve identity error message. #2623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amass01
force-pushed
the
identityerror
branch
from
2d2a591
to
b8f42ad
Compare
amass01
changed the title
|
Screen recording of the global error handling: Screen.Recording.2021-10-16.at.14.03.34.mov |
lukebp
approved these changes
Oct 16, 2021
There was a problem hiding this comment.
tACK of firefox
I really don't like the way react handles these global errors. It trains the developer to just hit esc on errors in order to bybass the error overlay. There's not much we can do about it though. The react devs feel strongly about it and this is not something that is going to change.
|
Needs code approval from @tiagoalvesdulce. |
|
Updated error message.
|
This was referenced Nov 16, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new react error boundary to handle global identity error.
The identity error can be thrown in various modals and error boundaries
is react's way to handle such errors.
Implementation:
IdentityErrorBoundaryto catch global identity error.useCarshhook in order to crash inside the component treewhen an identity error is thrown from an async action.
isIdentityErrorand use it cross the app.React error boundaries
Closes #2617.