-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
multi: add dcr wallet client. #49
Conversation
Consider renaming this PR to "wallet: add contract script functions" so we can get it in. I don't want to block wallet development while you're working on DEX API pieces. |
0219cd4
to
6ce48d3
Compare
will be adding to the initial with new commits. |
89498b5
to
93bf97f
Compare
Definitely on the right track, though the
I'm leaning towards #1, but I'm not crazy about merging the |
@buck54321 Either way is OK with me, although leaving this opened until the btc wallet client is up might benefit both PRs, although that's likely to result in more iterations to get them both merged. Your call. |
I think we should merge it after review. Let's not fret too much about tests, since they would likely need substantial rewrites after the interface is reworked anyway. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lots of work needed, but some good stuff here. I'll bring it all together with the BTC wallet. Ideally we would never merge something in this state of completion, but since I'm taking over this work and this code will help, I'm thinking we can do it this time.
Work towards #36.